Video tests fix - #7
Conversation
|
pylint report for this pull_request: $ PYTHONPATH=./lms/djangoapps:./lms/lib:./cms/djangoapps:./cms/lib:./common/lib:./common/djangoapps pylint --rcfile=pylintrc --output-format=colorized $(git diff master --name-only | grep -i '\.py$')
************* Module xmodule.video_module
W0511: 98: TODO (vshnayder): This is not being called right now, so the position
W0511:110: TODO (vshnayder): Get and save duration of youtube video, then return
W0223:154:VideoDescriptor: Method 'get_html' is abstract in class 'HTMLSnippet' but is not overridden@shnayder, can we manage your TODOs? |
|
I put those in sometime last summer, I think. Feel free to do whatever On Fri, May 31, 2013 at 3:45 AM, Vasyl Nakvasiuk
|
|
I see build failures, but I don't think it's related to your changes. Can you coordinate with @jzoldak: VersionConflict: (distribute 0.6.30 (/mnt/virtualenvs/edx-feature-branch-tests/lib/python2.7/site-packages), Requirement.parse('distribute==0.6.28')) |
Reports:tests + coverage $ coverage run `which django-admin.py` test --traceback --settings=lms.envs.test --pythonpath=. --logging-clear-handlers $(git diff master --name-only | grep -i '\.py$')
......
-----------------------------------------------------------------------------
6 tests run in 2.7 seconds (6 tests passed)
$ coverage report -m $(git diff master --name-only | grep -i '\.py$')
Name Stmts Miss Cover Missing
--------------------------------------------------------------------------------
common/lib/xmodule/xmodule/video_module 66 0 100%
lms/djangoapps/courseware/tests/__init__ 34 0 100%
lms/djangoapps/courseware/tests/test_video_mongo 8 0 100%
lms/djangoapps/courseware/tests/test_video_xml 45 0 100%
--------------------------------------------------------------------------------
TOTAL 153 0 100%pylint Your code has been rated at 10.00/10 (previous run: 10.00/10) |
|
👍 assuming the code is what I reviewed in edx/edx-platform-pre-clean#2121 |
|
LGTM 👍 Sorry for the delay, I had already looked that this pull request but got confused with the repo switch over. |
|
One small comment: consider squashing commits before merging (using rebase interactive). Many commits are just small changes. |
|
@rocha, ok. I will make "rebase -i". |
|
@rocha, done. |
|
👍 Go ahead and merge 😄 |
|
@rocha, so I can press the green button? :) |
|
Yes, you got two good to go. Go ahead and merge. |
ghost
mentioned this pull request
Change exam button to say "final check" instead of "check"
…OAuth to amplify-master * commit 'c641571329ec33f16f2c9ba544a029d7e18bfb75': Add overrides decorator for amplify oauth backend implementation Add comments and change the oauth provider to fqa server
# This is the 1st commit message: ENT-385 change error msg for confirm email # This is the commit message #2: remove changed msgid from po files # This is the commit message #3: add name to AUTHORS file # This is the commit message #4: remove lastfailed file # This is the commit message #5: GradingPolicyChanged Signal Handler https://openedx.atlassian.net/browse/EDUCATOR-393 # This is the commit message #6: EDUCATOR-435 | Include enrollment status in in course and problem grade reports. # This is the commit message #7: Change visibility to access. EDUCATOR-396 # This is the commit message #8: LEARNER-923 Make Pattern Library support tabs transparent # This is the commit message #9: Conform to WCAG 2 AA contrast minimums for Google OAuth. Also apply variables for FB/Linkedin OAuth2 rather than leave color hashes hanging around. # This is the commit message #10: Updated auto_auth endpoint to always return JSON Defaulting to a plaintext response makes no sense for an endpoint that is intended to be used by machines for testing. The endpoint now returns JSON only unless a redirect action is triggered. # This is the commit message #1: Fix the activation email support link in the dashboard sidebar # This is the commit message #2: Mask grades on progress page according to "Show Correctness" setting. # This is the commit message #3: More celery logging # This is the commit message #4: Eventing for grading policy change # This is the commit message #5: More specific grace_course logging # This is the commit message #6: Add course overrides of waffle flags. # This is the commit message #7: Mark test as flaky, and remove flaky from a fixed test. EDUCATOR-511 # This is the commit message #8: Fix for LEARNER-859: Updating styling on the course updates page to more clearly differentiate between multiple updates. Specifically: - Updated styling on date in the top left corner - Added horizontal line between updates - Removed ability to toggle updates on and off - Cleaned up code to always show all updates:
…lment_deactivated Caliper Event: edx.course.enrollment.deactivated
CAM2-53 Fix missing and broken translations
Learners Notification Approved-by: Vladyslav Zherebkin
6 participants
Tests for video player were fixed.
@rocha, @chrisndodge please review.
Old pull request on edx-platform-pre-clean: https://github.com/edx/edx-platform-pre-clean/pull/2121